Fix receiver tooltip (#3648)

betaflight · Nov 29, 2023 · faac1d5 · faac1d5
1 parent 5fc5f51
commit faac1d5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 17 deletions.
diff --git a/src/css/tabs/receiver.less b/src/css/tabs/receiver.less
@@ -658,9 +658,6 @@
 			&:nth-child(2) {
 				width: 20px;
 			}
-			div {
-				width: 27px;
-			}
 		}
 		.gui_box {
 			float: left;

diff --git a/src/js/Features.js b/src/js/Features.js
@@ -140,7 +140,10 @@ Features.prototype.generateElements = function (featuresElements) {
             element += `type="checkbox"/></td><td><div>${newFeatureName}</div>`;
             element += `<span class="xs" i18n="feature${featureName}"></span></td>`;
             element += `<td><span class="sm-min" i18n="feature${featureName}"></span>`;
-            element += `${feature_tip_html}</td></tr>`;
+            if (feature.haveTip) {
+                element += feature_tip_html;
+            }
+            element += '</td></tr>';
 
             const newElement = $(element);
 

diff --git a/src/js/tabs/receiver.js b/src/js/tabs/receiver.js
@@ -409,19 +409,11 @@ receiver.initialize = function (callback) {
         });
 
         function checkShowSerialRxBox() {
-            if (FC.FEATURE_CONFIG.features.isEnabled('RX_SERIAL')) {
-                $('div.serialRXBox').show();
-            } else {
-                $('div.serialRXBox').hide();
-            }
+            $('div.serialRXBox').toggle(FC.FEATURE_CONFIG.features.isEnabled('RX_SERIAL'));
         }
 
         function checkShowSpiRxBox() {
-            if (FC.FEATURE_CONFIG.features.isEnabled('RX_SPI')) {
-                $('div.spiRxBox').show();
-            } else {
-                $('div.spiRxBox').hide();
-            }
+            $('div.spiRxBox').toggle(FC.FEATURE_CONFIG.features.isEnabled('RX_SPI'));
         }
 
         function checkShowElrsBindingPhrase() {

diff --git a/src/tabs/receiver.html b/src/tabs/receiver.html
@@ -85,9 +85,6 @@
                             </table>
                         </div>
                     </div>
-                </div>
-
-                <div class="feature">
                     <div class="gui_box grey">
                         <div class="gui_box_titlebar">
                             <div class="spacer_box_title" i18n="configurationRSSI"></div>