Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtx tab fix for device without vtx tables #2087

Merged
merged 1 commit into from Jul 5, 2020
Merged

vtx tab fix for device without vtx tables #2087

merged 1 commit into from Jul 5, 2020

Conversation

rtlopez
Copy link
Contributor

@rtlopez rtlopez commented Jun 25, 2020 •
edited

Fixes #2086 in vtx page if connected device doesn't support tables.

@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

McGiverGim
McGiverGim approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
One advanced suggestion for the next time 😋 , if your "text" is like:
Fixes #2086
Github will close the Issue when merging the PR automatically. There are more "special" words, more info here: https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

@McGiverGim McGiverGim linked an issue Jun 25, 2020 that may be closed by this pull request
Vtx page broken if vtx table not available #2086
Closed
@asizon
Copy link
Member

asizon commented Jun 25, 2020

But, Im not sure if the Video Transmitter tab implementation allows to work here without vtx_table support @McGiverGim ?
Maybe we need to hide tab also if USE_VTX_TABLE is false?

@McGiverGim
Copy link
Member

No, it works. You can't define the different tables, but it uses the "default" old values and you can select the band/channel.

@McGiverGim McGiverGim mentioned this pull request Jun 30, 2020
Merged
@mikeller mikeller added this to the 10.7.1 milestone Jul 5, 2020
@mikeller mikeller merged commit 9d54c9a into betaflight:master Jul 5, 2020
mikeller added a commit to mikeller/betaflight-configurator that referenced this pull request Jul 6, 2020
@mikeller
Merge pull request betaflight#2087 from rtlopez/vtx_no_table_fix
afed7ec 
vtx tab fix for device without vtx tables
mikeller added a commit that referenced this pull request Jul 6, 2020
@mikeller
Merge pull request #2087 from rtlopez/vtx_no_table_fix
d636ca9 
vtx tab fix for device without vtx tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@mikeller mikeller mikeller approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
None yet
Milestone
10.7.1
Development

Successfully merging this pull request may close these issues.

Vtx page broken if vtx table not available
4 participants
@rtlopez @asizon @McGiverGim @mikeller