Adjust LQ OSD element preview according to selected serial RX provider #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomgomba
changed the title
atomgomba
force-pushed
the
add-xf-lq-osd-preview
branch
from
d83e486
to
8d7b172
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
atomgomba
changed the title
mikeller
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OSD Tab is activated the RX config gets queried through MSP unconditionally because it seems to me that there's no way to distinguish between the default value of
serialrx_provider(which is0) and whenserialrx_provideris not yet set.