Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select default serial port #2169

Merged
merged 1 commit into from Sep 20, 2020
Merged

select default serial port #2169

merged 1 commit into from Sep 20, 2020

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 4, 2020 •
edited

ℹ️ Working with the configurator it would be nice to have the port automatically detected.

  • Added support for detecting tty recognition for Linux and OSX to skip the cu port.
  • Added support for CP210x besides STM.
  • Added sorting of the port list.
  • Fixed dfu mode.

McGiverGim
McGiverGim requested changes Sep 4, 2020
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, all of this without testing it, so maybe I'm wrong at some place ;)

src/main.html Outdated Show resolved Hide resolved
src/js/port_handler.js Outdated Show resolved Hide resolved
@haslinghuis haslinghuis force-pushed the select_connect branch 3 times, most recently from 81a565f to 2ccaa8a Compare September 4, 2020 15:41
@haslinghuis haslinghuis force-pushed the select_connect branch 5 times, most recently from 8330626 to 468209f Compare September 4, 2020 23:42
McGiverGim
McGiverGim requested changes Sep 5, 2020
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the i18n.

The total code of handling of ports is a mesh, I will fix a lot of things, but is outside of this PR. The PR is ok to me.

src/main.html Outdated Show resolved Hide resolved
McGiverGim
McGiverGim previously approved these changes Sep 5, 2020
View reviewed changes
@haslinghuis haslinghuis force-pushed the select_connect branch 2 times, most recently from 32478c6 to 9bc982c Compare September 10, 2020 11:12
@haslinghuis
Copy link
Member Author

haslinghuis commented Sep 10, 2020 •
edited

⚠️ Seems master didn't even go into dfu mode. Had to restructure a lot but it works like a charm now. All fixed now.

@haslinghuis haslinghuis force-pushed the select_connect branch 5 times, most recently from 1284336 to d92094d Compare September 11, 2020 00:42
@haslinghuis haslinghuis marked this pull request as draft September 11, 2020 02:19
@haslinghuis haslinghuis marked this pull request as ready for review September 12, 2020 01:52
@haslinghuis haslinghuis force-pushed the select_connect branch 4 times, most recently from a8909e2 to e1a1c97 Compare September 12, 2020 23:21
@haslinghuis haslinghuis force-pushed the select_connect branch 5 times, most recently from 646a36b to 5506898 Compare September 14, 2020 00:11
@haslinghuis
Copy link
Member Author

haslinghuis commented Sep 14, 2020 •
edited

Thanks for testing!

✔️ Added CP210x to the comparison (using CP210 because its a CP2102 ?)!
📝 Removed references to last_used_port because it didn't seems to be used.

@mikeller Could you please test again because lacking hardware on this side.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikeller mikeller merged commit 5b4d9b9 into betaflight:master Sep 20, 2020
@haslinghuis haslinghuis deleted the select_connect branch September 20, 2020 10:22
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 21, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
503df19 
…flight#2169
@haslinghuis haslinghuis mentioned this pull request Sep 21, 2020
Merged
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 22, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
fb797d6 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 22, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
ad002a0 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 22, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
1979d61 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 22, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
a671ea0 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 22, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
aa85c20 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 22, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
dda0da3 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 23, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
bea468c 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 23, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
17d32cb 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 23, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
cce9d05 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 23, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
ef21477 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 25, 2020
@haslinghuis
Unlock DFU using FC boot button and improve auto-reconnect after beta…
bd9b0bd 
…flight#2169
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 25, 2020
@haslinghuis
Unlock DFU using FC boot button after betaflight#2169
38060a5
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 25, 2020
@haslinghuis
Unlock DFU using FC boot button after betaflight#2169
068ecac
haslinghuis added a commit to haslinghuis/betaflight-configurator that referenced this pull request Sep 25, 2020
@haslinghuis
Unlock DFU using FC boot button after betaflight#2169
49ad949
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Oct 5, 2020
@haslinghuis @chmelevskij
Unlock DFU using FC boot button after betaflight#2169
cc1c055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeller mikeller mikeller approved these changes

@McGiverGim McGiverGim McGiverGim left review comments

Assignees
No one assigned
Labels
RN: IMPROVEMENT
Projects
None yet
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @mikeller @McGiverGim