Move Switchery library to npm/yarn #2242
Conversation
|
Again, this Karma thing... now the tests are trying to load the GUI, the GUI tries to load the Switchery, it uses |
McGiverGim
force-pushed
the
move_switchery_yarn
branch
from
d062923
to
f6c651b
Compare
|
Finally it seems the |
| @@ -66,7 +67,7 @@ | |||
| <script type="text/javascript" src="./node_modules/three/examples/js/renderers/Projector.js"></script> | |||
| <script type="text/javascript" src="./js/libraries/jquery.flightindicators.js"></script> | |||
| <script type="text/javascript" src="./node_modules/semver-min/umd/index.js"></script> | |||
| <script type="text/javascript" src="./js/libraries/switchery/switchery.js"></script> | |||
| <script type="text/javascript" src="./node_modules/switchery-latest/dist/switchery.min.js"></script> | |||
There was a problem hiding this comment.
Changing this to type="module" should alleviate the in-browser woes.
There was a problem hiding this comment.
Added, but I can't see the difference.
The library has two version, one in the root of the folder, that I think is a pure module, and the other in the dist folder that I think is a browserify version of it.
Sorry, all of this is new to me. I have read a little about modules, but I can't see all the implications until I use it more...
There was a problem hiding this comment.
The comment overlapped with your latest change.
Using the browserified version (where available) as text/javascript will work. Using the non-browserified version as module will work as well. Not absolutely sure which one is better, but my hunch is to use the module version for all modules, as this can be done consistently.
Also, your current version has got two type= attributes. 😉
There was a problem hiding this comment.
True 🙀
I will do some tests tomorrow to confirm your thoughts.
There was a problem hiding this comment.
@mikeller finally I ended letting the browserify version. If I change to the module version:
- We need to use require (the node version for module import) because the import can only be used into another module, so we need to start migrating our others js to modules if we want to use import. With require it works.
- We need to change our Karma tests to be executed in node and not in browser. I have seen that this can be accomplished using Jasmine as Karma framework. If not it does not understand the require. Maybe it can understand the import.
So for this PR I think is better to make the things simple and let this changes for a future PR when we start to migrate our js to modules.
There was a problem hiding this comment.
Yeah, that's fair enough for now - we can do the migration to consumption of resources as modules at a later stage.
McGiverGim
force-pushed
the
move_switchery_yarn
branch
from
f6c651b
to
7a81d20
Compare
McGiverGim
force-pushed
the
move_switchery_yarn
branch
from
7a81d20
to
4776611
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Moves the switchery library to the npm/yarn form.
We were using this: https://github.com/abpetkov/switchery
but it seems it is not directly published into npm, so I took one of the forks that seems similar: https://www.npmjs.com/package/switchery-latest