New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix require modules with Cordova #2262
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This was less involved to browserify than I expected. 😅 |
@WalcoFPV can you confirm that the Android build is not totally fixed with this? I suppose that the |
@McGiverGim Yes |
With this PR pending the I think we have two big "open" themes for Android support:
We need the answer to this two themes first and after that, in a future, we can recommend to use simple wrapper for common operations (filesystem, clipboard, etc.) that can help to maintain the Node/Cordova compatibility. We will need to be cautious with this type of inclusions because we are seeing that we can break Cordova fast... |
@WalcoFPV, @McGiverGim: Should we merge this, or do we want to keep hacking away at a better solution for Cordova? |
If we are going to accept the require way of adding modules (no restrict to import), I think we need to merge it. I will revert the fs backend module in the next days to make Android work again. |
This fixes the importation of modules with
require
with Cordova (#2246)