Change lexical scope utils #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
Dec 13, 2020
src/js/utils/window_watchers.js
Outdated
| } | ||
|
|
||
| if (Array.isArray(windows)) { | ||
| windows.forEach((el) => applyBinding(el, key, val)); | ||
| windows.forEach((el) => this.applyBinding(el, key, val)); |
There was a problem hiding this comment.
Why are you making this recursive?
mikeller
reviewed
Dec 13, 2020
src/js/utils/window_watchers.js
Outdated
| this.applyBinding(windows, key, val); | ||
| } | ||
|
|
||
| windowWatcherUtil.applyBinding = function(win, key, val) { |
There was a problem hiding this comment.
Keeping this as a local scoped function seems to be an easier to understand way of doing this.
haslinghuis
force-pushed
the
utils
branch
4 times, most recently
from
919e7f7
to
9dc8e32
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mikeller
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.