Fix out of bounds error in pid_tuning #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
changed the title
haslinghuis
force-pushed
the
fix-pid-balloon
branch
from
b0f2217
to
ee4e8ef
Compare
mikeller
previously approved these changes
Dec 16, 2020
mikeller
reviewed
Dec 16, 2020
src/js/tabs/pid_tuning.js
Outdated
| @@ -2412,7 +2412,7 @@ TABS.pid_tuning.updateRatesLabels = function() { | |||
| ); | |||
| } | |||
| // then display them on the chart | |||
| for (let i = 0; i <= balloons.length; i++) { | |||
| for (let i = 0; i < balloons.length; i++) { | |||
There was a problem hiding this comment.
These could easily be done as for ( of ):
for (balloon of balloons) {
balloon.balloon();
}
same for the above.
There was a problem hiding this comment.
😜 I've tried but then the last element is still undefined.
Let me change it - I see what was wrong we both forgot to initialize the balloon 🤣
Tested and fixed.
haslinghuis
force-pushed
the
fix-pid-balloon
branch
from
ee4e8ef
to
88aa7e1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
McGiverGim
approved these changes
Dec 17, 2020
mikeller
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two index out of bounds errors in PID Tuning tab.