Arrange configuration and motor tab

[haslinghuis]

Fixes: #2304

Summary:

• Move mixer and motor/esc features from configuration to motor tab
• Move servo test to servos tab

Suggestions:

• Styling changes notice, mixer and buttons @asizon / @limonspb
• Fix MOTOR_STOP alignment with ESC_SENSOR and align padding on different places @TheIsotopes
• Move reorder Motors and Motor direction to Mixer settings @ZZYZX / @limonspb
• Move mixer from graph to configuration and put configuration before testing @McGiverGim
• Stop motor testing when making configuration changes (+ disable motor test after making changes before reboot) @mikeller

Thanks @asizon @bizmar @chmelevskij @limonspb @McGiverGim @mikeller @TheIsotopes @ZZYZX

[chmelevskij]

Do these need to be run in parallel or they can be in sequence?

If we make initialise async we could do something like for the sequential

try {
  await MSP.promise(MSPCodes.MSP_SERVO_CONFIGURATIONS);
  await MSP.promise(MSPCodes.MSP_SERVO_MIX_RULES);
  await MSP.promise(MSPCodes.MSP_RC);
  await MSP.promise(MSPCodes.MSP_BOXNAMES);
  load_html();
} catch(error) {
  console.log(error)
}

Or for parallel

try {
  await Promise.all([
    MSP.promise(MSPCodes.MSP_SERVO_CONFIGURATIONS),
    MSP.promise(MSPCodes.MSP_SERVO_MIX_RULES),
    MSP.promise(MSPCodes.MSP_RC),
    MSP.promise(MSPCodes.MSP_BOXNAMES),
  ])
  load_html();
} catch(error) {
  console.log(error)
}

[haslinghuis]

There is no particular sequence as they don't depend on each other. So the first solution would work but I'm in doubt in what advantage the parallel solution has over the former.

[haslinghuis]

Thanks @chmelevskij - it's working 😜 Updated configuration.js, motors.js and servos.js.

[chmelevskij]

If id doesn't matter about the sequence I'd use Promise.all, bunch of awaits will block and wait for the previous to finish so you might get a bit of a lag if execution time adds up to 1s or smth

[McGiverGim]

We added some time ago one MSP command to execute various MSP commands at once. I don't remember the ID but can be useful for that.

[McGiverGim]

I found it: #1605

[mikeller]

MSP commands can definitely not be run in parallel - the firmware and the protocol lack the means to sequentialise / recombine responses.

[mikeller]

As for MSP_MULTIPLE_MSP, I'd be reluctant to use this as a wrapper to group multiple commands in configurator - this will break and require another rewrite as soon as one of the combined frames (request or response) exceeds 255 bytes in length, which will happen sooner or later due to the MSP protocol's nature of having commands grow in lenght with every change.

[mikeller]

@haslinghuis: Seeing how much change is still going on in this pull request, can you please change this to 'draft' status so reviewers can hold off until it is ready for review?

[McGiverGim]

@haslinghuis did you see my comment about MSP_MULTIPLE_MSP above?

[haslinghuis]

@McGiverGim yes but there is no example how to call it. And I was very very busy trying to fix the servos test. Motor tab and configuration tab are ready and @asizon offered to look at servos because I am on dead trail with it.

[haslinghuis]

Thanks @McGiverGim - your review was very helpfull. Addressed your points and it should be good to go now:

[McGiverGim]

LGTM, but as I said, others will not think the same :)

[haslinghuis]

Minor improvement on width in motor testing (E values were too condensed on a smaller screen) and moved @limonspb buttons to the content_toolbar. The mixer section now does also comply with the ESC/Motor Features styling.

@mikeller having addressed stopping of motors properly when changing settings please take a look again.

[haslinghuis]

Maybe should hide the motor direction and reorder motors buttons also when testing is active - implemented.

[haslinghuis]

Tools are disabled after changing settings too now.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

13 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[McGiverGim]

@mikeller can we merge this? It seems finished to me. Some change is pending?

[mikeller]

@McGiverGim: I'll review. This has had so many repetitive changes pushed into it that I stopped looking at it.

[limonspb]

Congratulations, @haslinghuis very good job! :)