Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null when CLI autocomplete resource #2363

Merged
merged 1 commit into from Dec 31, 2020
Merged

Fix null when CLI autocomplete resource #2363

merged 1 commit into from Dec 31, 2020

Conversation

McGiverGim
Copy link
Member

Fixes #2358

It seems that for the library we use is not the same null and undefined in the return of the replace function. To let the code consistent I return $1 now that produces the same output than undefined.

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikeller mikeller added this to the 10.8.0 milestone Dec 30, 2020
@mikeller mikeller merged commit ebb6130 into betaflight:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeller mikeller mikeller approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
None yet
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

Resource command is not working
2 participants
@McGiverGim @mikeller