Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow margin of 25 for aux ranges #2454

Merged
merged 1 commit into from Mar 24, 2021

Conversation

john-k3nnedy
Copy link
Contributor

Aux ranges that are 25 wide are actually supported and working fine when configured via CLI, but the UI has a lower limit of 50. This changes the UI to match the CLI behavior.

Aux ranges that are 25 wide are actually supported and working fine when configured via CLI, but the UI has a lower limit of 50. This changes the UI to match the CLI behavior.
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, in firmware this is defined here:

https://github.com/betaflight/betaflight/blob/7d0c1ebad9f188892ac17d5a0f6177ba18fc4181/src/main/fc/rc_modes.h#L96-L109

This changes are more than 4 years old. I don't know if for some version it was 50, I didn't found it. So to me is ok the change.

@mikeller mikeller added this to the 10.8.0 milestone Mar 24, 2021
@mikeller mikeller merged commit 740b4a7 into betaflight:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants