New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added motor/esc protocol settings to configuration tab #25
Conversation
Awesome! Just tested and it works! |
I think if we get the rc rate yaw and looptime thingy in I will already release a new version and advertise it a bit for usage. That's the hardest needed part and my main motivation for configurator |
} | ||
esc_protocol_e.val(PID_ADVANCED_CONFIG.fast_pwm_protocol+1); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiteAnton: Shouldn't this be gated by a check for version > 2.8.1-RC1? Otherwise it will display options not available to users of older firmware.
@borisbstyle: Will look into adding the new rc rates tonight. Did you have any progress in getting the curve to go with it working? |
I am working on replacing the looptime with gyro/pid denom. Almost done, just wanting to update the pid process when changing gyro speed. |
@KiteAnton, @borisbstyle: I think to go along with gyro/pid denom, we should probably look into adding support to enable / disable gyro / baro / mag sensors to the GUI. It's been a source for user confusion in the past that sensors got disabled by loop time changes, and there was no obvious way to reenable them. |
@mikeller @KiteAnton |
@borisbstyle: All good, just wanted to know if it was almost ready, so I could do all the UI changes in one go. |
@mikeller
|
Cleaned up the layout: see 61297fb |
As requested in #23 .
Fast pwm protocol, unsynced pwm and motor pwm rate in configuration tab.