Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added motor/esc protocol settings to configuration tab #25

Merged
merged 1 commit into from Jun 20, 2016
Merged

Added motor/esc protocol settings to configuration tab #25

merged 1 commit into from Jun 20, 2016

Conversation

KiteAnton
Copy link
Contributor

As requested in #23 .
Fast pwm protocol, unsynced pwm and motor pwm rate in configuration tab.

@borisbstyle borisbstyle merged commit 4d4e455 into betaflight:master Jun 20, 2016
@borisbstyle
Copy link
Member

Awesome! Just tested and it works!

@borisbstyle
Copy link
Member

I think if we get the rc rate yaw and looptime thingy in I will already release a new version and advertise it a bit for usage. That's the hardest needed part and my main motivation for configurator

}
esc_protocol_e.val(PID_ADVANCED_CONFIG.fast_pwm_protocol+1);


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KiteAnton: Shouldn't this be gated by a check for version > 2.8.1-RC1? Otherwise it will display options not available to users of older firmware.

@mikeller
Copy link
Member

@borisbstyle: Will look into adding the new rc rates tonight. Did you have any progress in getting the curve to go with it working?

@KiteAnton
Copy link
Contributor Author

I am working on replacing the looptime with gyro/pid denom. Almost done, just wanting to update the pid process when changing gyro speed.

@mikeller
Copy link
Member

@KiteAnton, @borisbstyle: I think to go along with gyro/pid denom, we should probably look into adding support to enable / disable gyro / baro / mag sensors to the GUI. It's been a source for user confusion in the past that sensors got disabled by loop time changes, and there was no obvious way to reenable them.

@borisbstyle
Copy link
Member

@mikeller
Not yet. But thats really least important thing for now. I would rather first like to have functional stuff in it to make things easier for the users.

@KiteAnton
Great man! Both should be able to be updated seperatily.

@mikeller
Copy link
Member

@borisbstyle: All good, just wanted to know if it was almost ready, so I could do all the UI changes in one go.

@borisbstyle
Copy link
Member

borisbstyle commented Jun 20, 2016

@mikeller
In web java script

function calculateDegSec(input,rc_rate,rate,rc_expo){
var setpoint = input;
var RPY = 1-Math.abs(input)_rate;
var rxRAW = input_1000;
var curve = rxRAW_rxRAW/1000000;
setpoint = ((setpoint_curve)rc_expo+setpoint(1-rc_expo))*( rc_rate/10);

return Math.round(((2000_(1/RPY))_setpoint)*100)/100;
}

@KiteAnton KiteAnton deleted the esc_motorsettings branch June 20, 2016 20:11
@skaman82
Copy link
Contributor

Cleaned up the layout: see 61297fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants