Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect use of callback for control sticks window. #2523

Merged
merged 1 commit into from Jul 6, 2021
Merged

Fixed incorrect use of callback for control sticks window. #2523

merged 1 commit into from Jul 6, 2021

Conversation

mikeller
Copy link
Member

Fixes a bug when opening the Control sticks window:

Uncaught TypeError: callback is not a function
    at Object.DarkTheme.isDarkThemeEnabled (DarkTheme.js:24)
    at receiver.js:509
    at extensions::app.window:209

image

@mikeller mikeller added this to the 10.8.0 milestone Jun 29, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@haslinghuis haslinghuis self-assigned this Jun 29, 2021
@blckmn
Copy link
Member

blckmn commented Jul 6, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 5ed5d04 into betaflight:master Jul 6, 2021
@mikeller mikeller deleted the fix_control_sticks_window branch October 10, 2021 13:05
@mikeller mikeller modified the milestones: 10.8.0, 10.7.1 Oct 10, 2021
mikeller pushed a commit that referenced this pull request Oct 10, 2021
@blckmn @mikeller
Auto merged - #2523 at Tue, 06 Jul 2021 08:17:09 GMT
bef07bf 
Fixed incorrect use of callback for control sticks window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon asizon approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX Tested
Projects
None yet
Milestone
10.7.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikeller @blckmn @limonspb @haslinghuis @asizon