Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scrolling conditional and allow auto-detect board when no board selected #2554

Merged
merged 1 commit into from Sep 26, 2021
Merged

Remove scrolling conditional and allow auto-detect board when no board selected #2554

merged 1 commit into from Sep 26, 2021

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 4, 2021 •
edited

Fixes: #2551
Fixes: #2609

@haslinghuis haslinghuis added this to the 10.8.0 milestone Aug 4, 2021
@haslinghuis haslinghuis force-pushed the remove-scrolling branch 4 times, most recently from 855b1f1 to ce8e1b1 Compare August 5, 2021 01:00
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

McGiverGim
McGiverGim reviewed Aug 5, 2021
View reviewed changes
src/js/tabs/firmware_flasher.js Outdated
@@ -29,6 +29,7 @@ firmware_flasher.initialize = function (callback) {
self.parsed_hex = undefined;

const unifiedSource = 'https://api.github.com/repos/betaflight/unified-targets/contents/configs/default';
const divReleaseInfo = 'div.release_info';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the element $('div.release_info) exist at this point?

If yes, usually we create directly the element:

const divRealeaseInfoElement = $('div.release_info');

and we use it later in the rest of the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found out something weird. Using the $(selector) as a constant was not evaluated at the places we are using them.
I mean when using $('selector') it works not when it's assigned to a constant 😕

McGiverGim
McGiverGim previously approved these changes Aug 5, 2021
View reviewed changes
@haslinghuis haslinghuis self-assigned this Aug 5, 2021
@asizon
Copy link
Member

asizon commented Aug 22, 2021

Im not sure about removing our current autoscroll here @haslinghuis , for me is a good functionality, maybe we can go to a nonscroll fix in some cases?

@haslinghuis haslinghuis changed the title Remove scrolling in firmware_flasher Remove scrolling in firmware_flasher and allow auto-detect board when no board selected Sep 20, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis changed the title Remove scrolling in firmware_flasher and allow auto-detect board when no board selected Remove scrolling conditional and allow auto-detect board when no board selected Sep 20, 2021
@haslinghuis
Copy link
Member Author

@asizon made scrolling conditional

@asizon asizon added the Tested label Sep 26, 2021
@blckmn
Copy link
Member

blckmn commented Sep 26, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 2dad799 into betaflight:master Sep 26, 2021
@haslinghuis haslinghuis deleted the remove-scrolling branch September 26, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@asizon asizon asizon approved these changes

@McGiverGim McGiverGim McGiverGim left review comments

Assignees

@haslinghuis haslinghuis

Labels
RN: FEATURE Tested
Projects
None yet
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

disable autoscroll in firmware flasher tab Bug? - Auto-Detect deactivated if no board selected
5 participants
@haslinghuis @asizon @blckmn @McGiverGim @limonspb