Small patch

[haslinghuis]

Fixes selector (which also wrongly did target Rates Roll Center and Expo) and refactored condition variable to something meaningful as requested in previous PR.

[ctzsnooze]

Changing the background colour of the PID numbers may have been a part of 4.2, but I think it is a bad idea.
It makes for very poor legibility in some situations...

Let's keep the numeric background the same; we have the warning box, and the colour behind the slider itself, that's enough.
Or at least, if we want to put them back, please make a separate PR to discuss that.
This PR should focus on bug-fixes arising from user feedback.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ctzsnooze]

Checked, tested.

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> PASS
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> PASS
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[yngndrw]

@ctzsnooze

Changing the background colour of the PID numbers may have been a part of 4.2, but I think it is a bad idea. It makes for very poor legibility in some situations... Let's keep the numeric background the same; we have the warning box, and the colour behind the slider itself, that's enough. Or at least, if we want to put them back, please make a separate PR to discuss that. This PR should focus on bug-fixes arising from user feedback.

Only just seen this comment, but the slider heatmaps were added in this PR:
#1839
... and changes for dark mode were added in this PR:
#1843

The text used to be black which made the numbers far more legible. The heatmaps were added so that you could see what changes each slider were making at a glance, the colouring of the sliders themselves are not equivalent.