[chore] migrate remaining deprecated chrome storage API calls to ConfigStorage JSON implementation.

[haslinghuis]

We need to migrate deprecated API's.

This PR is removing chrome.storage API and uses the ConfigStorage.js we had in place already instead.

Deprecated API	Suggested API	Link
chrome.storage	Cache API	https://web.dev/storage-for-the-web/
chrome.fileSystem	Native FileSystem API	https://web.dev/file-system-access/
chrome.serial	Web Serial API	https://web.dev/serial/
chrome.sockets.tcp	WebSockets	https://web.dev/websocketstream/
chrome.usb	Web USB API	https://web.dev/usb/

[chmelevskij]

I'd remove callbacks if using local storage. Would make it a bit easier to reason about since now storage is all sync.

[chmelevskij]

So to fix the callback issue we need to refactor the get as well

betaflight-configurator/src/js/ConfigStorage.js

Lines 7 to 32 in 78287a1

	get: function(key, callback) {
	if (Array.isArray(key)) {
	let obj = {};
	key.forEach(function (element) {
	try {
	obj = {...obj, ...JSON.parse(window.localStorage.getItem(element))};
	} catch (e) {
	// is okay
	}
	});
	callback(obj);
	} else {
	const keyValue = window.localStorage.getItem(key);
	if (keyValue) {
	let obj = {};
	try {
	obj = JSON.parse(keyValue);
	} catch (e) {
	// It's fine if we fail that parse
	}
	callback(obj);
	} else {
	callback({});
	}
	}
	},

    get: function(key) {
        if (Array.isArray(key)) {
            let obj = {};
            key.forEach(function (element) {
                try {
                    obj = {...obj, ...JSON.parse(window.localStorage.getItem(element))};
                } catch (e) {
                    // is okay
                }
            });
            return obj;
        } else {
            const keyValue = window.localStorage.getItem(key);
            if (keyValue) {
                let obj = {};
                try {
                    obj = JSON.parse(keyValue);
                } catch (e) {
                    // It's fine if we fail that parse
                }
                return obj;
            } else {
                return {};
            }
        }
    },

Then in the actual code which was using the callback, return value of get needs to be assigned to a variable and later on used in the callback body logic.

[haslinghuis]

Squashed and rebased

[limonspb]

Proposal (discussed with @haslinghuis )
leave it for 10.9 or 10.8.1

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> FAIL
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[haslinghuis]

Rebased

[haslinghuis]

Squashed and rebased

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!