Fix integrated yaw usage

[asizon]

Allow manual pid change when integrated yaw is enabled.

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> PASS
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[haslinghuis]

After testing I found we have to press the Enable button twice.

Moving the code to pid_tuning.js solves it:

        $('input[id="useIntegratedYaw"]').change(function() {
            const checked = $(this).is(':checked');
            if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) {
                this.sliderPidsMode = 0;
            }
            $('#pid_main .pid_data input').prop('disabled', !checked);
            $('#pidTuningIntegratedYawCaution').toggle(checked);
        }).change();

[ctzsnooze]

In my testing, the PR allows me to edit manually edit PID values, when integrated yaw is enabled, but if I save the Profile, then my changes are lost and I cannot edit the values anymore.

[haslinghuis]

@ctzsnooze Can't reproduce as I've tested

[asizon]

Yes, we need to take a look into this issue. Ithink sliders are not changing correctly from RPY to off.

[haslinghuis]

Sorry @asizon I made a typo in my first suggestion. Now I have more time I had a fresh look and found you should move the fix to around line 1936 as this only applies to sliders. We can leave the code around 550 untouched:

$('input[id="useIntegratedYaw"]').change(() => {
    if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) {
        TuningSliders.sliderPidsMode = 0;
    }
    TuningSliders.updatePidSlidersDisplay();
}

The typo was this.sliderPidsMode instead of TuningSliders.sliderPidsMode.

[klutvott123]

So enabling integrated yaw should disable sliders for RPY, not just Y?

[haslinghuis]

Hmm you suggest setting slider to RP mode instead to OFF? Makes sense to me. Testing now.

[klutvott123]

I suggest setting it to RP IF it's currently set to RPY

[haslinghuis]

@asizon

Worked out the changes needed @klutvott123 suggested:

diff2.txt

[ctzsnooze]

@asizon - do you have time to update this PR and test it? We need to resolve this for 10.8 RC1 as soon as possible.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
34 Code Smells

No Coverage information
0.0% Duplication

[ctzsnooze]

Tested, works by pushing slider mode to RP mode.