Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiver tab update for 4.3 #2671

Merged
merged 1 commit into from Dec 3, 2021

Conversation

ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Nov 28, 2021

Incorporates #2667 and #2635 into a single PR - they are now closed. All comments from those PR's have been addressed I think.

Changes the Receiver drop-down labels as follows:

Old New
PPM RX input PPM/CPPM (single wire)
Serial-based receiver (SPEKSAT, SBUS, SUMD Serial (Via UART)
PWM RX input (one wire per channel) PWM (one wire per channel)
MSP RX input (control via MSP port) MSP (control via MSP port)
SPI RX support SPI (e.g. built-in Rx)

Updates the general message at the top of the Receiver tab to emphasise the warnings - especially the ADC warning, which is really important with the newer, fast Rx links. Direct link from Failsafe note to our Failsafe Testing doc. Slightly changed the serial message also.

Rearranges the html so that the the craft icon is in the left column, to make more effective use of the available space. Happy for the craft icon to go below the bars, but I couldn't figure how to do that, and it looks cool at the top I think.

Any other suggestions / ideas to improve the receiver tab for 4.3?

How it looks with this PR:

suggestedRxLayout

vs how it used to look:

prevRxLayout

limonspb
limonspb previously approved these changes Nov 28, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis added this to In progress in Finalizing Firmware 4.3 Release via automation Nov 28, 2021
@blckmn
Copy link
Member

blckmn commented Nov 29, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis moved this from Approval Needed to Last Review Needed in Finalizing Firmware 4.3 Release Dec 1, 2021
@limonspb limonspb merged commit c7af0c4 into betaflight:master Dec 3, 2021
Finalizing Firmware 4.3 Release automation moved this from Last Review Needed to Finished (Merged) Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants