Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new feedforwardgroup options #2673

Merged
merged 1 commit into from Nov 28, 2021
Merged

Fix new feedforwardgroup options #2673

merged 1 commit into from Nov 28, 2021

Conversation

asizon
Copy link
Member

@asizon asizon commented Nov 28, 2021

I dont know were and why we loose msp write lines for these two new feedforward options.
Maybe we loose afeter this @haslinghuis ??? is really weird. Also added these 2 new parameters to fc.js
92948e2

@asizon asizon self-assigned this Nov 28, 2021
@asizon asizon added this to the 10.8.0 milestone Nov 28, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctzsnooze
Copy link
Member

Thanks, Asizon.
Tested and checked, all feedforward values save correctly.
I also checked all the othervalues in the PID_tuning page, they seem to save and refresh correctly.

@limonspb
Copy link
Member

limonspb commented Nov 28, 2021 •
edited

looks like they disappeared in this PR
#2638
@haslinghuis could you please check if something else was unintentionally removed in that merge commit for just in case.
image

@blckmn
Copy link
Member

blckmn commented Nov 28, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

I guess rebase went wrong (thinking it wasn't merged yet), As this already was introduced here:
#2656

@haslinghuis haslinghuis added this to In progress in Finalizing Firmware 4.3 Release via automation Nov 28, 2021
@haslinghuis haslinghuis merged commit 9240349 into betaflight:master Nov 28, 2021
Finalizing Firmware 4.3 Release automation moved this from In progress to Done Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@asizon asizon

Labels
Merged RN: BUGFIX Tested
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asizon @ctzsnooze @limonspb @blckmn @haslinghuis