Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add no-vars rule to match sonar cloud #2692

Merged
merged 1 commit into from
Jan 18, 2022
Merged

chore: add no-vars rule to match sonar cloud #2692

merged 1 commit into from
Jan 18, 2022

Conversation

chmelevskij
Copy link
Member

@chmelevskij chmelevskij commented Dec 18, 2021 •
edited
Loading

match some of the rules to sonar cloud to reduce the amount on PRs

@chmelevskij chmelevskij changed the title chore: add todos for rules chore: add no-vars rule to match sonar cloud Dec 18, 2021
@chmelevskij chmelevskij marked this pull request as ready for review December 18, 2021 07:18
@haslinghuis
Copy link
Member

Yeah src/js/protocols/stm32usbdfu.js was the only file I didn't touch yet.

haslinghuis
haslinghuis previously approved these changes Dec 19, 2021
View reviewed changes
@haslinghuis haslinghuis added this to the 10.8.0 milestone Dec 19, 2021
ctzsnooze
ctzsnooze previously approved these changes Dec 22, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Dec 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Jan 3, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 9, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Jan 10, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 18, 2022
@asizon asizon merged commit 27b3afb into betaflight:master Jan 18, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon asizon approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@chmelevskij chmelevskij

Labels
RN: IMPROVEMENT
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chmelevskij @haslinghuis @blckmn @limonspb @ctzsnooze @asizon