Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prefer template rule #2696

Merged
merged 5 commits into from Jan 22, 2022

Conversation

chmelevskij
Copy link
Member

Another rule to match code style in sonarcloud.

haslinghuis
haslinghuis previously approved these changes Dec 21, 2021
haslinghuis
haslinghuis previously approved these changes Jan 9, 2022
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 9, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Jan 9, 2022
limonspb
limonspb previously approved these changes Jan 12, 2022
asizon
asizon previously approved these changes Jan 18, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 18, 2022
@asizon asizon added this to the 10.8.0 milestone Jan 18, 2022
asizon
asizon previously approved these changes Jan 18, 2022
haslinghuis
haslinghuis previously approved these changes Jan 18, 2022
@chmelevskij chmelevskij dismissed stale reviews from haslinghuis and asizon via 83ab0ce January 18, 2022 13:55
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Jan 18, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis moved this from Firmware to Configurator in Finalizing Firmware 4.3 Release Jan 18, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 22, 2022
@limonspb limonspb merged commit d0d3141 into betaflight:master Jan 22, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants