Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logging tab error about modules #2727

Merged
merged 1 commit into from Jan 6, 2022
Merged

fix: logging tab error about modules #2727

merged 1 commit into from Jan 6, 2022

Conversation

chmelevskij
Copy link
Member

Fixes that console error about import only being usable in modules.

@sonarcloud
Copy link

sonarcloud bot commented Dec 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@haslinghuis haslinghuis added this to the 10.8.0 milestone Jan 2, 2022
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 2, 2022
@blckmn
Copy link
Member

blckmn commented Jan 3, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis moved this from For discussion to In Progress in Finalizing Firmware 4.3 Release Jan 4, 2022
@ctzsnooze ctzsnooze merged commit 6f421b4 into betaflight:master Jan 6, 2022
Finalizing Firmware 4.3 Release automation moved this from In Progress to Finished (Merged) Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon Awaiting requested review from asizon

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chmelevskij @blckmn @limonspb @haslinghuis @ctzsnooze