Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions for CI #2735

Merged
merged 3 commits into from Jan 29, 2022
Merged

Use GitHub Actions for CI #2735

merged 3 commits into from Jan 29, 2022

Conversation

mathiasvr
Copy link
Contributor

GitHub Actions workflow for running tests and building on all platforms.

Nightly release is not included, but I can add it here or in later PR if preferred.

McGiverGim
McGiverGim requested changes Jan 4, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see changes in files that don't seem to belong to the PR (.editorconfig,)

.editorconfig Outdated Show resolved Hide resolved
@McGiverGim
Copy link
Member

Nightly release is not included, but I can add it here or in later PR if preferred.

I suppose is better to add it here, if not, we can't remove the Azure part. With only this, both builds are fired.

McGiverGim
McGiverGim reviewed Jan 4, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
haslinghuis
haslinghuis previously approved these changes Jan 4, 2022
View reviewed changes
@blckmn
Copy link
Member

blckmn commented Jan 4, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

McGiverGim
McGiverGim previously approved these changes Jan 8, 2022
View reviewed changes
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 9, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Jan 9, 2022
@mathiasvr mathiasvr dismissed stale reviews from McGiverGim and haslinghuis via 55d27c6 January 9, 2022 22:43
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 29, 2022
@limonspb limonspb merged commit 3018ac3 into betaflight:master Jan 29, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Jan 29, 2022
@mathiasvr mathiasvr deleted the pr-github-actions-ci branch February 13, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon Awaiting requested review from asizon

@limonspb limonspb Awaiting requested review from limonspb

Assignees

@mathiasvr mathiasvr

Labels
build system improvement
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mathiasvr @McGiverGim @blckmn @chmelevskij @haslinghuis @limonspb