Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets: minor fixes #2736

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Presets: minor fixes #2736

merged 1 commit into from
Jan 5, 2022

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Jan 4, 2022 •
edited
Loading

Four small changes/fixes:

  1. Preselect not just TUNE but also RC_LINK, RATES and RC_SMOOTHING as probably the four most popular things.
  2. Allow #$ INCLUDE of the files with upper case.
  3. On the preset source dialog when making active a source it will save it's changes it automatically (if name, link were changed)
  4. Small style change for the preset filter fields when something is selected there:
    image

@limonspb limonspb force-pushed the presets_minor_fixes branch 2 times, most recently from 1784254 to 2f2ab55 Compare January 4, 2022 02:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@limonspb limonspb self-assigned this Jan 4, 2022
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 4, 2022
@haslinghuis haslinghuis added this to the 10.8.0 milestone Jan 4, 2022
@haslinghuis haslinghuis moved this from For discussion to In Progress in Finalizing Firmware 4.3 Release Jan 4, 2022
chmelevskij
chmelevskij reviewed Jan 4, 2022
View reviewed changes
src/tabs/presets/presets.js

TABS.presets.updateSingleSelectStyle = function(select) {
const selectedOptions = select.multipleSelect("getSelects", "text");
const isSomethingSelected = (0 !== selectedOptions.length);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cast this to boolean instead of yoda comparisons 😉

Suggested change
const isSomethingSelected = (0 !== selectedOptions.length);
const isSomethingSelected = !!selectedOptions.length;

@blckmn
Copy link
Member

blckmn commented Jan 4, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@haslinghuis haslinghuis merged commit 621f8de into betaflight:master Jan 5, 2022
Finalizing Firmware 4.3 Release automation moved this from In Progress to Finished (Merged) Jan 5, 2022
@limonspb limonspb deleted the presets_minor_fixes branch November 7, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon asizon approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

Assignees

@limonspb limonspb

Labels
RN: BUGFIX
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@limonspb @blckmn @chmelevskij @haslinghuis @asizon