Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portable build to windows #2739

Merged
merged 1 commit into from Jan 12, 2022

Conversation

McGiverGim
Copy link
Member

This adds a "portable" zip build to windows (win32 and win64) releases. In this way some of the complains about having different versions installed, or about problems with the installer will be gone.

It modifies the name of the "installer" to be similar to the portable one. The linux version adds the portable word too.

image

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@haslinghuis
Copy link
Member

@McGiverGim Is this for 10.7.x only? Or do we get 32bit builds for 10.8.x now too?

@McGiverGim
Copy link
Member Author

@McGiverGim Is this for 10.7.x only? Or do we get 32bit builds for 10.8.x now too?

We only build the 64 bit version. We can build the 32 bit version manually only.

@asizon asizon added this to the 10.8.0 milestone Jan 5, 2022
@asizon asizon added the Tested label Jan 5, 2022
@blckmn
Copy link
Member

blckmn commented Jan 5, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@asizon asizon linked an issue Jan 7, 2022 that may be closed by this pull request
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 9, 2022
@haslinghuis haslinghuis moved this from For discussion to In Progress in Finalizing Firmware 4.3 Release Jan 9, 2022
@haslinghuis haslinghuis moved this from In Progress to Configurator in Finalizing Firmware 4.3 Release Jan 9, 2022
@limonspb
Copy link
Member

limonspb commented Jan 9, 2022

@McGiverGim thats really cool.
One question - once we release or in nightly builds, are we going to have separate downloads for portable/installer or it will be one zip folder?

@McGiverGim
Copy link
Member Author

Separate. One for installer, another for portable.

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 12, 2022
@haslinghuis haslinghuis moved this from Firmware to Configurator in Finalizing Firmware 4.3 Release Jan 12, 2022
@haslinghuis haslinghuis merged commit c34821e into betaflight:master Jan 12, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Finished (Merged) Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Why it needs to remove old versions of Configurator?
5 participants