Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter tooltip messages for 4.3 #2744

Merged
merged 1 commit into from Jan 10, 2022
Merged

Update filter tooltip messages for 4.3 #2744

merged 1 commit into from Jan 10, 2022

Conversation

ctzsnooze
Copy link
Member

Updates the filter messages for the help icons in 4.3

@ctzsnooze ctzsnooze self-assigned this Jan 9, 2022
@ctzsnooze ctzsnooze changed the title update filter messages Update filter tooltip messages for 4.3 Jan 9, 2022
asizon
asizon requested changes Jan 9, 2022
View reviewed changes
locales/en/messages.json Outdated Show resolved Hide resolved
locales/en/messages.json Outdated Show resolved Hide resolved
locales/en/messages.json Outdated Show resolved Hide resolved
locales/en/messages.json Outdated Show resolved Hide resolved
@ctzsnooze
Copy link
Member Author

ctzsnooze commented Jan 9, 2022 •
edited

Thanks @asizon - now all static cutoffs have the label Static Cutoff Frequency [Hz], like this:

Screen Shot 2022-01-10 at 08 54 10

asizon
asizon requested changes Jan 9, 2022
View reviewed changes
locales/en/messages.json Outdated Show resolved Hide resolved
@ctzsnooze
update filter messages
993b59a 
update filter messages
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 10, 2022
@haslinghuis haslinghuis added this to the 10.8.0 milestone Jan 10, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Jan 10, 2022
@blckmn
Copy link
Member

blckmn commented Jan 10, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 10, 2022
@asizon asizon merged commit b691139 into betaflight:master Jan 10, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon asizon approved these changes

Assignees

@ctzsnooze ctzsnooze

Labels
Ready to Merge Tested
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ctzsnooze @blckmn @limonspb @haslinghuis @asizon