Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord link fix: make permanent (never expire) #2751

Merged
merged 1 commit into from Jan 13, 2022
Merged

Discord link fix: make permanent (never expire) #2751

merged 1 commit into from Jan 13, 2022

Conversation

limonspb
Copy link
Member

Forgot that by default discord invite link is being expired after 7 days.
Changing the link to a permanent one.

blckmn
blckmn previously requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@blckmn blckmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use

HTTPS://discord.betaflight.com/invite

@limonspb limonspb dismissed blckmn’s stale review January 12, 2022 11:43

good call, changed

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@haslinghuis haslinghuis added this to the 10.8.0 milestone Jan 12, 2022
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 12, 2022
@blckmn
Copy link
Member

blckmn commented Jan 12, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Jan 12, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 13, 2022
@haslinghuis haslinghuis merged commit 822aab7 into betaflight:master Jan 13, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

Assignees

@limonspb limonspb

Labels
Housekeeping
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@limonspb @blckmn @haslinghuis @ctzsnooze @KarateBrot