Fixes multiple-select in darkmode #2764
Conversation
haslinghuis
added this to For discussion
in Finalizing Firmware 4.3 Release
via automation
haslinghuis
moved this from For discussion
to Configurator
in Finalizing Firmware 4.3 Release
| @@ -73,6 +73,10 @@ | |||
| display: inline-block; | |||
| } | |||
|
|
|||
| .ms-drop ul>li.hide-radio:focus, .ms-drop ul>li.hide-radio:hover { | |||
There was a problem hiding this comment.
could you please add something like:
#presets_detailed_dialog
.ms-drop ul>li.hide-radio:focus, .ms-drop ul>li.hide-radio:hover {
so that this style has been applied only for this particular dialog.
There was a problem hiding this comment.
Umm, really needed? Its already on presets_detailed_dialog css file so only works here.
There was a problem hiding this comment.
this css file is included from main html, so all the styles from this .css file will be applied to the whole Configurator. Unless you narrow them with more specific selectors.
There was a problem hiding this comment.
Ouch! Understood, I thought that it is included amd comes only in presets dialog html and js files.
remove hover background from presets dialog add specific selector
asizon
force-pushed
the
fix_multiple-select_darkmode
branch
from
e7562f4
to
3d3ba09
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Done!Ready for merge |
|
AUTOMERGE: (FAIL)
|
haslinghuis
moved this from Finished (Merged)
to Configurator
in Finalizing Firmware 4.3 Release
haslinghuis
moved this from Configurator
to Finished (Merged)
in Finalizing Firmware 4.3 Release
Fixes muiltiple-select hover in darkmode. This plugin is used for new Presets feature.
Before:
With this PR:
