Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove publish unit tests #2783

Merged
merged 1 commit into from Feb 9, 2022
Merged

Conversation

mathiasvr
Copy link
Contributor

This removes the CI step that publishes unit test results, because it doesn't really work with PRs from forked repos, and worse it fails on PRs from e.g. dependabot.

It looks like it possible to fix this by moving it to a separate workflow, but I'm not sure how useful that is.

I think it's best to remove this now and maybe look into this later, but this is not an important step but more a convenience.

As it doesn't work for forked repos
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was beautiful, but unfortunately we don't use too much the unit tests... So to me is ok to remove it, make it work complicates the workflow according the instructions.
But I'm open to include it later.

@asizon asizon added this to the 10.8.0 milestone Feb 9, 2022
@blckmn
Copy link
Member

blckmn commented Feb 9, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Feb 9, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Feb 9, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Feb 9, 2022
@haslinghuis haslinghuis merged commit 7490d08 into betaflight:master Feb 9, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Feb 9, 2022
@mathiasvr mathiasvr deleted the ci-fix branch February 13, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants