Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide second iterm relax tooltip #2792

Merged

Conversation

McGiverGim
Copy link
Member

Fixes #2719

image

This PR includes two commits:

  • The first, hides the cutoff iterm relax tooltip when the iterm relax is disabled.
  • The second one, gives a little more room to the first column of the table. This is a workaround to the real problem: we can have some translations bigger than the original, so the column must auto adjust. If someone wants to look at the auto adjust and fix it in a real manner will be great. But for now, with this change the current translations will fit.

The final result, in native english is:
image

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@asizon asizon added this to the 10.8.0 milestone Feb 2, 2022
@asizon
Copy link
Member

asizon commented Feb 2, 2022

Looks good @McGiverGim, I forget this needed fix sorry.

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Feb 2, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Feb 2, 2022
@blckmn
Copy link
Member

blckmn commented Feb 3, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Feb 4, 2022
@ctzsnooze
Copy link
Member

Perhaps for long names we can include a hyphen?

@haslinghuis
Copy link
Member

CamelCase preferred

@haslinghuis haslinghuis merged commit a37b08e into betaflight:master Feb 4, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Big translations / Double tootilp in Iterm Relax
5 participants