Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix changes listing and tag name #2809

Merged
merged 2 commits into from Feb 13, 2022
Merged

Conversation

mathiasvr
Copy link
Contributor

This fixes the missing changes listing in the release notes of the nightly build and adds date to the release tag.

I discussed with @McGiverGim how I was hoping to change the way releases are tagged to e.g. build-123 or v10.7.2-123 instead of being based on dates, which is already part of the tag and release. However, unfortunately it turned out to not be simple to preserve release ordering in the web listing and probably requires removing or renaming all the existing tags.
So instead this PR also brings back the date based tags.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mathiasvr
Copy link
Contributor Author

@blckmn Can you update the branch protection rules to use the new CI test and build jobs?

@blckmn
Copy link
Member

blckmn commented Feb 13, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved until we find a way to change the tag format...

@mathiasvr
Copy link
Contributor Author

Seems like release ordering is buggy in general.

@blckmn blckmn merged commit c71a82b into betaflight:master Feb 13, 2022
@mathiasvr mathiasvr deleted the ci-fix-listing branch February 14, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants