Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide old artifact links #2818

Merged
merged 1 commit into from Feb 20, 2022
Merged

Hide old artifact links #2818

merged 1 commit into from Feb 20, 2022

Conversation

asizon
Copy link
Member

@asizon asizon commented Feb 16, 2022

Hide outdated artifact links when another PR workflow push.

image

@asizon asizon self-assigned this Feb 16, 2022
@asizon asizon added this to the 10.8.0 milestone Feb 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

McGiverGim
McGiverGim approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we have talked in the Slack chat, I think is better to include this as a step in the artifact-links.yml action.
But I approve it because this only works with pull_request, until we find a workaround.

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Feb 16, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Feb 16, 2022
@blckmn
Copy link
Member

blckmn commented Feb 17, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Feb 20, 2022
@limonspb limonspb merged commit e131657 into betaflight:master Feb 20, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@asizon asizon

Labels
RN: BUILD SYSTEM
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asizon @blckmn @McGiverGim @limonspb @haslinghuis