Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RX model preview for different rates system #2829

Merged
merged 1 commit into from Feb 27, 2022
Merged

Fix RX model preview for different rates system #2829

merged 1 commit into from Feb 27, 2022

Conversation

McGiverGim
Copy link
Member

This a fast fix for the quad preview model in the RX tab. Now, with ACTUAL as default, it was slow, almost stopped, because it used the ACTUAL rates as BETAFLIGHT rates. This fixes the preview depending on the rates.

I think a better fix is to integrate this in the RateCurve.js file, but I didn't want to touch too much code in the RC phase that we are now, because the pid tuning tab will need to be adapted too to the changes.

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Feb 25, 2022
@haslinghuis haslinghuis added this to the 10.8.0 milestone Feb 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Feb 25, 2022
@blckmn
Copy link
Member

blckmn commented Feb 26, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Feb 27, 2022
@haslinghuis haslinghuis merged commit 1c94c65 into betaflight:master Feb 27, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon asizon approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@McGiverGim @blckmn @haslinghuis @ctzsnooze @asizon