Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show firmware loaded in firmware flasher tab #2834

Merged
merged 1 commit into from Feb 27, 2022
Merged

Show firmware loaded in firmware flasher tab #2834

merged 1 commit into from Feb 27, 2022

Conversation

haslinghuis
Copy link
Member

image

McGiverGim
McGiverGim requested changes Feb 26, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!! Only one suggestion...

locales/en/messages.json Outdated Show resolved Hide resolved
@haslinghuis haslinghuis force-pushed the show_firmware_loaded branch 3 times, most recently from 00d602e to 822c073 Compare February 26, 2022 16:17
@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Feb 26, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@daleckystepan
Copy link
Member

daleckystepan commented Feb 26, 2022 •
edited

Tested on MacOS, works fine. Thank you.

@betaflight betaflight deleted a comment from github-actions bot Feb 26, 2022
@betaflight betaflight deleted a comment from github-actions bot Feb 26, 2022
@betaflight betaflight deleted a comment from github-actions bot Feb 26, 2022
@haslinghuis haslinghuis merged commit 6235372 into betaflight:master Feb 27, 2022
@haslinghuis haslinghuis deleted the show_firmware_loaded branch February 27, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@haslinghuis @blckmn @daleckystepan @McGiverGim @limonspb @ctzsnooze