New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make serial connection timeout dynamic #2838
Conversation
This comment has been minimized.
This comment has been minimized.
8609105
to
e75addc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
The commit does several things...
Here is a console log after clicking 'Save' in Ports, where it took 3.1s to reconnect
Tested, works well. |
Seems a new improvement not a bug fix, weneed to release 10.8.0 this year |
e75addc
to
f8371af
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
AUTOMERGE: (FAIL)
|
As a long time request this PR makes the serial reconnection timeout dynamic with a timeout of 10 seconds.
The PR makes sure we have a new connection on reinitialization and waits for the connection to be ready and fixes the bug connecting to soon with a predetermined timeout now verified by timestamp.