Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets: support Marked description layout #2841

Merged
merged 1 commit into from Mar 1, 2022
Merged

Presets: support Marked description layout #2841

merged 1 commit into from Mar 1, 2022

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Mar 1, 2022 •
edited

Allowing Marked for presets description to make them nicer.

new optional metaproperty:
#$ PARSER: MARKED/TEXT

default is TEXT

Corresponding presets PR:
betaflight/firmware-presets#193

Example:

image

Dompurify library is added for safety to sanitize html.

To test:
Download Configurator from this PR.
Add custom preset source - yours or this one:
link: https://github.com/limonspb/firmware-presets
branch: marked-demo

@limonspb limonspb mentioned this pull request Mar 1, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.1% 0.1% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Mar 1, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Mar 1, 2022
@haslinghuis haslinghuis added this to the 10.8.0 milestone Mar 1, 2022
@haslinghuis haslinghuis merged commit ea6958f into betaflight:master Mar 1, 2022
Finalizing Firmware 4.3 Release automation moved this from For discussion to Finished (Merged) Mar 1, 2022
@limonspb limonspb deleted the marked branch November 7, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon Awaiting requested review from asizon

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

Assignees
No one assigned
Labels
RN: IMPROVEMENT
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@limonspb @blckmn @McGiverGim @chmelevskij @haslinghuis