Fix MSP flow, make MSP timeout dynamic #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
haslinghuis
added this to For discussion
in Finalizing Firmware 4.3 Release
via automation
haslinghuis
moved this from For discussion
to Configurator
in Finalizing Firmware 4.3 Release
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
This comment has been minimized.
This comment has been minimized.
McGiverGim
reviewed
Mar 5, 2022
src/js/tabs/motors.js
Outdated
| @@ -579,7 +579,7 @@ TABS.motors.initialize = function (callback) { | |||
| // Amperage | |||
| function power_data_pull() { | |||
| motorVoltage.text(i18n.getMessage('motorsVoltageValue', [FC.ANALOG.voltage])); | |||
| motorMahDrawingElement.text(i18n.getMessage('motorsADrawingValue', [FC.ANALOG.amperage.toFixed(2)])); | |||
| motorMahDrawingElement.text(i18n.getMessage('motorsADrawingValue', [FC.ANALOG.amperage?.toFixed(2)])); | |||
There was a problem hiding this comment.
The value was initial undefined causing an error. Faster processing seem to have side effects. Until now it's the only one found while optimizing MSP. Updated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix_msp
branch
2 times, most recently
from
646b2a9
to
194ebb7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix_msp
branch
2 times, most recently
from
fc45c9e
to
d1354d5
Compare
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix_msp
branch
3 times, most recently
from
a9b0068
to
8f50699
Compare
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix_msp
branch
2 times, most recently
from
b7277eb
to
d2117cf
Compare
haslinghuis
changed the title
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix_msp
branch
2 times, most recently
from
55a1717
to
8dd0d9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add parameters to status bar Use async and await on serial_backend
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
limonspb
approved these changes
Jun 27, 2022
McGiverGim
approved these changes
Jun 27, 2022
haslinghuis
moved this from Configurator
to Ready to merge
in Finalizing Firmware 4.4 Release
blckmn
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSP_STATUSvsMSP_STATUS_EXas it was called unsupported (without software version control).Note:
With a lower timeout the code shows more timeouts but overall the code is processing more calls optimizing processing.