Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli tab: vertical flex fix and removing scroll bars #2903

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Cli tab: vertical flex fix and removing scroll bars #2903

merged 1 commit into from
Apr 23, 2022

Conversation

limonspb
Copy link
Member

Before PR (when window is small enough):
image

After PR:
image

@limonspb limonspb self-assigned this Apr 22, 2022
@limonspb limonspb added this to Bug Tracker in Finalizing Firmware 4.3 Release via automation Apr 22, 2022
@limonspb limonspb added this to the 10.8.0 milestone Apr 22, 2022
@limonspb limonspb marked this pull request as draft April 22, 2022 22:59
@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@limonspb limonspb marked this pull request as ready for review April 22, 2022 23:53
@blckmn
Copy link
Member

blckmn commented Apr 23, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

Finalizing Firmware 4.3 Release automation moved this from Bug Tracker to Firmware Apr 23, 2022
@haslinghuis haslinghuis moved this from Firmware to Configurator in Finalizing Firmware 4.3 Release Apr 23, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Apr 23, 2022
@haslinghuis haslinghuis moved this from Firmware to Configurator in Finalizing Firmware 4.3 Release Apr 23, 2022
@limonspb limonspb merged commit b98e042 into betaflight:master Apr 23, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Finished (Merged) Apr 23, 2022
@limonspb limonspb deleted the cli_height_fix branch November 7, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon Awaiting requested review from asizon

Assignees

@limonspb limonspb

Labels
RN: BUGFIX Tested
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@limonspb @blckmn @McGiverGim @chmelevskij @haslinghuis @ctzsnooze