Make "Activate bootloader" button use bootloader in flash if it exists #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutvott123
force-pushed
the
reboot-options
branch
from
7d483ad
to
145d567
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
haslinghuis
approved these changes
Apr 23, 2022
klutvott123
added this to Bug Tracker
in Finalizing Firmware 4.3 Release
via automation
|
Removed the for discussion label as this is code that should have been there since the bootloader options and the flag in targetCapabilities was added in the firmware |
haslinghuis
moved this from Firmware
to Configurator
in Finalizing Firmware 4.3 Release
|
AUTOMERGE: (FAIL)
|
limonspb
approved these changes
Apr 24, 2022
blckmn
approved these changes
Apr 24, 2022
Finalizing Firmware 4.3 Release
automation
moved this from Firmware
to Finished (Merged)
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's missing code that causes rebooting into the wrong bootloader when pressing the button.
From the discussion in betaflight/betaflight#11334 it looks like this button should reboot into the bootloader that allows flashing firmware. For targets that have bootloader in flash, this is the one we want.
In addition to this I propose we change the behaviour of theblcommand to use the default bootloader.Edit: Logic in cli code looks like it already behaves as it should
Fixes betaflight/betaflight#11334