Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version component margin and darktheme background for status bar #2915

Merged
merged 1 commit into from
May 10, 2022
Merged

Fix version component margin and darktheme background for status bar #2915

merged 1 commit into from
May 10, 2022

Conversation

asizon
Copy link
Member

@asizon asizon commented May 8, 2022

image

image

@asizon asizon added this to the 10.8.0 milestone May 8, 2022
@asizon asizon self-assigned this May 8, 2022
@asizon asizon requested a review from chmelevskij May 8, 2022 08:03
@github-actions

This comment has been minimized.

Sign in to view
@asizon
Copy link
Member Author

asizon commented May 8, 2022 •
edited
Loading

@chmelevskij do you think we should go with this !important fix?Seems that now status bar component go before dark theme and version component

@asizon asizon changed the title Fix version component margin Fix version component margin and darktheme background for status bar May 8, 2022
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented May 8, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

chmelevskij
chmelevskij previously approved these changes May 8, 2022
View reviewed changes
haslinghuis
haslinghuis previously approved these changes May 8, 2022
View reviewed changes
@asizon
Copy link
Member Author

asizon commented May 9, 2022

I will update this pr to just darktheme fix.

@asizon asizon dismissed stale reviews from haslinghuis and chmelevskij via 2235247 May 9, 2022 19:35
@asizon
fix version component margin
2235247 
fix darktheme background

remove margin
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to Bug Tracker in Finalizing Firmware 4.3 Release via automation May 9, 2022
@haslinghuis haslinghuis moved this from Bug Tracker to Configurator in Finalizing Firmware 4.3 Release May 9, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware May 10, 2022
@haslinghuis haslinghuis merged commit d359bcf into betaflight:master May 10, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@asizon asizon

Labels
RN: BUGFIX
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@asizon @blckmn @McGiverGim @limonspb @chmelevskij @haslinghuis