Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSP_BOARD_INFO accumulation and localStorage Quota Exceeded #2937

Merged
merged 1 commit into from May 31, 2022
Merged

Fix MSP_BOARD_INFO accumulation and localStorage Quota Exceeded #2937

merged 1 commit into from May 31, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 29, 2022 •
edited

Fixes: #2938

  • Fixes FC.CONFIG.boardName parameter accumulating previous values.
  • Move Loader function in a try catch error statement.
  • Move Jenkins + firmware cache from localStorage to new SessionStorage to fix Exceeded Quota error.
  • Remove old keys from LocalStorage.

@haslinghuis haslinghuis added this to the 10.8.0 milestone May 29, 2022
@haslinghuis haslinghuis self-assigned this May 29, 2022
@haslinghuis haslinghuis added this to Needs work in Finalizing Firmware 4.3 Release via automation May 29, 2022
@haslinghuis haslinghuis moved this from Needs work to Ready for review in Finalizing Firmware 4.3 Release May 29, 2022
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-auto-detect branch 2 times, most recently from f8a295b to 095efbb Compare May 29, 2022 01:01
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented May 29, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis mentioned this pull request May 29, 2022
Closed
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Fix MSP_BOARD_INFO accumulation Fix MSP_BOARD_INFO accumulation and localStorage Quota Exceeded May 29, 2022
@haslinghuis haslinghuis marked this pull request as draft May 29, 2022 17:18
@haslinghuis haslinghuis force-pushed the fix-auto-detect branch 3 times, most recently from c21b9d5 to bae0dcb Compare May 29, 2022 21:59
@haslinghuis haslinghuis marked this pull request as ready for review May 29, 2022 22:01
@github-actions

This comment has been minimized.

Sign in to view
limonspb
limonspb suggested changes May 29, 2022
View reviewed changes
src/js/SessionStorage.js Outdated Show resolved Hide resolved
src/js/SessionStorage.js Outdated Show resolved Hide resolved
src/js/SessionStorage.js Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis requested a review from limonspb May 29, 2022 23:37
@github-actions

This comment has been minimized.

Sign in to view
limonspb
limonspb previously approved these changes May 30, 2022
View reviewed changes
@McGiverGim
Copy link
Member

What happens with old values stored in the local storage? They will remain there until the user deletes the folder in the computer?

chmelevskij
chmelevskij previously approved these changes May 30, 2022
View reviewed changes
@haslinghuis
Copy link
Member Author

haslinghuis commented May 30, 2022 •
edited

@McGiverGim

What happens with old values stored in the local storage? They will remain there until the user deletes the folder in the computer?

Pushed a new update to remove old keys

@haslinghuis haslinghuis dismissed stale reviews from chmelevskij and limonspb via 5ffba12 May 30, 2022 20:46
@haslinghuis haslinghuis force-pushed the fix-auto-detect branch 3 times, most recently from d9236de to 08803d2 Compare May 30, 2022 20:56
@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

McGiverGim
McGiverGim approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup is very simple, maybe we need to store some "version" in the localStorage, and act according to the change of version. But for the moment, I think is enough with your code. I suppose this is a exceptional situation and we can remove the cleaning in one or two versions.

@asizon asizon merged commit bed2b8a into betaflight:master May 31, 2022
Finalizing Firmware 4.3 Release automation moved this from Ready for review to Finished (Merged) May 31, 2022
@haslinghuis haslinghuis deleted the fix-auto-detect branch May 31, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@asizon asizon asizon approved these changes

@chmelevskij chmelevskij chmelevskij left review comments

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

Massive problems in the firmware flasher tab
6 participants
@haslinghuis @blckmn @McGiverGim @limonspb @chmelevskij @asizon