Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTX Device over MSP #2965

Merged
merged 1 commit into from Sep 14, 2022
Merged

VTX Device over MSP #2965

merged 1 commit into from Sep 14, 2022
+36 −0

Conversation

phobos-
Copy link
Contributor

@phobos- phobos- commented Jun 29, 2022

This PR is carrying configurator changes required for configuring MSP VTX device.
More information is in this PR: betaflight/betaflight#11705

@phobos- phobos- mentioned this pull request Jun 29, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jun 29, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jun 29, 2022
@phobos-
Copy link
Contributor Author

phobos- commented Sep 13, 2022

@haslinghuis is anything pending on this PR except review?

@haslinghuis
Copy link
Member

Asked for reviews on slack when I merged the firmware part.

McGiverGim
McGiverGim approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to me.

@haslinghuis haslinghuis moved this from Configurator to Ready to merge in Finalizing Firmware 4.4 Release Sep 13, 2022
@haslinghuis haslinghuis merged commit 7bf6084 into betaflight:master Sep 14, 2022
Finalizing Firmware 4.4 Release automation moved this from Ready to merge to Closed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@phobos- phobos-

Labels
Needs coordination with betaflight RN: FEATURE
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phobos- @blckmn @haslinghuis @McGiverGim @chmelevskij