Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watt Hours Consumed OSD element and post Flight Stat #2974

Merged
merged 1 commit into from Sep 29, 2022
Merged

Watt Hours Consumed OSD element and post Flight Stat #2974

merged 1 commit into from Sep 29, 2022

Conversation

jonmahoney15
Copy link
Contributor

A feature request was made to implement watt hour consumed on the osd.
This allows pilots who prefer reading Wh over other battery stats can
judge battery consumption.

@jonmahoney15
Watt Hours Consumed OSD element and post Flight Stat
8bc93fd 
A feature request was made to implement watt hour consumed on the osd.
This allows pilots who prefer reading Wh over other battery stats can
judge battery consumption.
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Jul 15, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jul 17, 2022
@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@jonmahoney15
Copy link
Contributor Author

jonmahoney15 commented Jul 18, 2022 •
edited

betaflight/betaflight/pull/11843

@haslinghuis haslinghuis moved this from Configurator to Ready to merge in Finalizing Firmware 4.4 Release Sep 20, 2022
@ctzsnooze ctzsnooze self-requested a review September 29, 2022 05:00
@haslinghuis haslinghuis merged commit 500dea5 into betaflight:master Sep 29, 2022
Finalizing Firmware 4.4 Release automation moved this from Ready to merge to Closed Sep 29, 2022
@haslinghuis haslinghuis mentioned this pull request Oct 7, 2022
Merged
@jonmahoney15 jonmahoney15 deleted the watt-hours-consumed-osd-element branch October 19, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@asizon asizon Awaiting requested review from asizon

Assignees
No one assigned
Labels
RN: FEATURE
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonmahoney15 @blckmn @haslinghuis @ctzsnooze