Add some missing style and minor bugfix #2996
Conversation
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
|
You can reopen this PR when you push something again |
ASDosjani
changed the title
ASDosjani
changed the title
src/js/tabs/led_strip.js
Outdated
| @@ -1121,7 +1144,7 @@ led_strip.initialize = function (callback, scrollPosition) { | |||
| return mc.color; | |||
| } | |||
| } | |||
| return ""; | |||
| return 3; //Throttle is the default | |||
There was a problem hiding this comment.
3 is the index of the throttle in the list.
There was a problem hiding this comment.
Please be more specific, What list?
There was a problem hiding this comment.
This one. There were no default value.
ASDosjani
force-pushed
the
list-fix
branch
2 times, most recently
from
99bb4d6
to
95250b0
Compare
This comment has been minimized.
This comment has been minimized.
haslinghuis
moved this from Configurator
to Ready to merge
in Finalizing Firmware 4.4 Release
ASDosjani
requested review from
blckmn,
haslinghuis and
asizon
and removed request for
asizon,
blckmn and
haslinghuis
haslinghuis
moved this from Needs work
to Ready to merge
in Finalizing Firmware 4.4 Release
This comment has been minimized.
This comment has been minimized.
src/js/tabs/led_strip.js
Outdated
| if (!areOverlaysActive(activeFunction)) $('.overlays').hide(); | ||
| if (!areModifiersActive(activeFunction)) $('.modifiers').hide(); | ||
| if (!areBlinkersActive(activeFunction)) $('.blinkers').hide(); | ||
| if (!isWarningActive(activeFunction)) $('.warningOverlay').hide(); | ||
| if (!isVtxActive(activeFunction)) $('.vtxOverlay').hide(); |
There was a problem hiding this comment.
| if (!areOverlaysActive(activeFunction)) $('.overlays').hide(); | |
| if (!areModifiersActive(activeFunction)) $('.modifiers').hide(); | |
| if (!areBlinkersActive(activeFunction)) $('.blinkers').hide(); | |
| if (!isWarningActive(activeFunction)) $('.warningOverlay').hide(); | |
| if (!isVtxActive(activeFunction)) $('.vtxOverlay').hide(); | |
| $('.overlays').toggle(areOverlaysActive(activeFunction); | |
| $('.modifiers').toggle(areModifiersActive(activeFunction); | |
| $('.blinkers').toggle(areBlinkersActive(activeFunction); | |
| $('.warningOverlay').toggle(isWarningActive(activeFunction); | |
| $('vtxOverlay').toggle(isVtxActive(activeFunction); |
Also remove the 5 paragraphs below
There was a problem hiding this comment.
It's not working, I tested.
There was a problem hiding this comment.
My bad, need to remove the negation ( ! ) (updated suggestion) and also need to remove the lines
There was a problem hiding this comment.
I found a better solution, please check.
There was a problem hiding this comment.
Using toggle is a much better and dense solution,
There was a problem hiding this comment.
You were right, it's working now.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
haslinghuis
moved this from Ready to merge
to Configurator
in Finalizing Firmware 4.4 Release
|
Mac works as expected... |
I added the missing styles to the selectable lists, those white boxes in dark mode just hurt my eyes so I made this fix. The
Larson scannerand theBlink alwaysoverlays didn't worked with each other properly so they toggle each other, only one of them can be used at a time. I noticed that the channel based color modifier doesn't have default value so I nominated the Throttle for this. Also updated deprecated .change() function.While I was making this fix it stood out that the switch animations doesn't work if I select anyting on the Led table. It is not related to my code, I tried to fix it but I couldn't. If anybody has time I would appreciate a fix for this.Edit: I could fix it.