Fix profile switching #2998
Merged
Fix profile switching #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
|
AUTOMERGE: (FAIL)
|
asizon
requested changes
Aug 30, 2022
| @@ -2494,12 +2493,12 @@ pid_tuning.initialize = function (callback) { | |||
| self.updating = false; | |||
|
|
|||
| // enable RC data pulling for rates preview | |||
| GUI.interval_add('receiver_pull', self.getReceiverData, true); | |||
| GUI.interval_add('receiver_pull', self.getReceiverData, 250, true); | |||
There was a problem hiding this comment.
Why we need a timer here now @haslinghuis ?
There was a problem hiding this comment.
It was missing a timer (bug) in the interval code. Without type checking like TS, JS did allow it to run.
Function is defined as
GuiControl.prototype.interval_add = function (name, code, interval, first) {
asizon
approved these changes
Aug 31, 2022
haslinghuis
moved this from Configurator
to Ready to merge
in Finalizing Firmware 4.4 Release
blckmn
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2997