Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSD checkbox #3018

Merged
merged 1 commit into from Sep 17, 2022
Merged

Fix OSD checkbox #3018

merged 1 commit into from Sep 17, 2022

Conversation

haslinghuis
Copy link
Member

Fix display of OSD checkbox.

Before:
image

After:
image

@haslinghuis haslinghuis added this to the 10.8.1 milestone Sep 4, 2022
@haslinghuis haslinghuis self-assigned this Sep 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Sep 4, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis moved this from Configurator to Ready to merge in Finalizing Firmware 4.4 Release Sep 17, 2022
@blckmn blckmn merged commit 7fdc62a into betaflight:master Sep 17, 2022
Finalizing Firmware 4.4 Release automation moved this from Ready to merge to Closed Sep 17, 2022
@haslinghuis haslinghuis deleted the fix-osd-checkbox branch September 18, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @blckmn @McGiverGim