Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update port selection after initialization #3027

Merged
merged 1 commit into from Oct 17, 2022
Merged

Update port selection after initialization #3027

merged 1 commit into from Oct 17, 2022

Conversation

ASDosjani
Copy link
Contributor

After the start of the configurator the msp selector or the manual port box didn't show up. This line fixes it.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Sep 24, 2022
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis moved this from Configurator to Ready to merge in Finalizing Firmware 4.4 Release Sep 24, 2022
@blckmn
Copy link
Member

blckmn commented Sep 24, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis moved this from Ready to merge to Configurator in Finalizing Firmware 4.4 Release Sep 24, 2022
haslinghuis
haslinghuis requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way we don't interfere with firmware flasher tab change function. As the change function is also called in serial_backend.js

src/js/port_handler.js Outdated Show resolved Hide resolved
haslinghuis
haslinghuis previously approved these changes Sep 25, 2022
View reviewed changes
@haslinghuis
Copy link
Member

haslinghuis commented Sep 25, 2022 •
edited

O wait, why did you change all occurrences ?

Please only update the original line 165.
The other lines are used in firmware flasher tab.

@ASDosjani
Copy link
Contributor Author

O wait, why did you change all occurrences ?

Please only update the original line 165. The other lines are used in firmware flasher tab.

Sorry, I thought they are doing the same thing.

haslinghuis
haslinghuis previously approved these changes Sep 25, 2022
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit a49a6b9 into betaflight:master Oct 17, 2022
Finalizing Firmware 4.4 Release automation moved this from Configurator to Closed Oct 17, 2022
@ASDosjani ASDosjani deleted the port_update branch June 11, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@ASDosjani ASDosjani

Labels
Ready to Merge RN: BUGFIX
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ASDosjani @blckmn @haslinghuis @limonspb