Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add anti gravity tooltip and fix scaling #3032

Merged
merged 1 commit into from Oct 12, 2022
Merged

add anti gravity tooltip and fix scaling #3032

merged 1 commit into from Oct 12, 2022

Conversation

haslinghuis
Copy link
Member

As requested by @ctzsnooze

@haslinghuis haslinghuis added this to the 10.9.0 milestone Oct 5, 2022
@haslinghuis haslinghuis self-assigned this Oct 5, 2022
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Oct 6, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim previously approved these changes Oct 6, 2022
View reviewed changes
@ctzsnooze
Copy link
Member

Thanks, @haslinghuis, that's great!
It might be good to make the scaling of the value such that when set to default of 80 (in the CLI), the number is shown as 8.0 in the configurator.
Tooltip can then say, '8.0 means about 8x...'.

@haslinghuis haslinghuis force-pushed the fix-anti-gravity branch 2 times, most recently from 182fc69 to c61a9b1 Compare October 7, 2022 00:24
@haslinghuis
Copy link
Member Author

Fixed.

@haslinghuis haslinghuis force-pushed the fix-anti-gravity branch 3 times, most recently from f0d7838 to c663c03 Compare October 7, 2022 00:32
ctzsnooze
ctzsnooze previously approved these changes Oct 7, 2022
View reviewed changes
@haslinghuis haslinghuis changed the title fix anti gravity tooltip add anti gravity tooltip and fix scaling Oct 7, 2022
@github-actions

This comment has been minimized.

Sign in to view
klutvott123
klutvott123 previously approved these changes Oct 7, 2022
View reviewed changes
@klutvott123 klutvott123 mentioned this pull request Oct 7, 2022
Merged
asizon
asizon requested changes Oct 11, 2022
View reviewed changes
src/js/tabs/pid_tuning.js Outdated

if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_45)) {
antiGravityGain.attr({ "min": "1", "max": "250", "step": "1" });
antiGravityGain.attr({ "min": "0.1", "max": "25.0", "step": "0.1" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this steping value afects to 10.8.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch (stepping was the same, but not max).

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member Author

Rebased and fixed requested change.

@haslinghuis haslinghuis merged commit 880f2c9 into betaflight:master Oct 12, 2022
Finalizing Firmware 4.4 Release automation moved this from Configurator to Closed Oct 12, 2022
@haslinghuis haslinghuis deleted the fix-anti-gravity branch October 12, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@asizon asizon asizon approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: IMPROVEMENT Tested
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@haslinghuis @blckmn @ctzsnooze @McGiverGim @klutvott123 @asizon