New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release.yml - target_commitish REF_NAME #3037

Merged

asizon merged 1 commit into betaflight:master from nerdCopter:20221007_release_workflow_ref_name

Oct 11, 2022

Member

nerdCopter commented Oct 7, 2022 •

edited

if a github action "release" workflow is manually triggered, and a branch is selected rather than master, then the draft-release wrongly points to master rather than the branch selected.
by adding target_commitish: ${{ GITHUB.REF_NAME }} to the softprops/action-gh-release step, this is rectified.

--

ignore my branch name, this was for personal/testing purposes


          release.yml - target_commitish REF_NAME

2b8c11c

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Member

blckmn commented Oct 7, 2022 •

edited

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> FAIL
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> FAIL
assigned to an approver -> FAIL
approver count at least three -> FAIL

haslinghuis assigned nerdCopter

haslinghuis added the RN: BUILD SYSTEM label

Contributor

github-actions bot commented Oct 7, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

haslinghuis requested a review from McGiverGim

October 7, 2022 21:23

haslinghuis added this to Configurator in Finalizing Firmware 4.4 Release

McGiverGim approved these changes

View reviewed changes

Member

McGiverGim left a comment

It's ok to me. This action is not being used, we have other that does the build after generating the release.

haslinghuis approved these changes

View reviewed changes

asizon approved these changes

View reviewed changes

asizon merged commit f4a0171 into betaflight:master

Finalizing Firmware 4.4 Release automation moved this from Configurator to Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment