Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable MSP configuration on MSP peripherals #3061

Merged
merged 1 commit into from Oct 31, 2022
Merged

Enable MSP configuration on MSP peripherals #3061

merged 1 commit into from Oct 31, 2022

Conversation

haslinghuis
Copy link
Member

Enable MSP configuration on peripherals with MSP communication automatically after save and reboot.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Oct 26, 2022
@haslinghuis haslinghuis self-assigned this Oct 26, 2022
@haslinghuis haslinghuis changed the title Enforce MSP on MSP peripherals Enforce MSP configuration on MSP peripherals Oct 26, 2022
@haslinghuis haslinghuis marked this pull request as draft October 26, 2022 20:55
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis marked this pull request as ready for review October 27, 2022 00:08
@haslinghuis haslinghuis force-pushed the enforce-msp branch 3 times, most recently from 8909cc0 to 2ecec91 Compare October 27, 2022 01:55
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Oct 27, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis changed the title Enforce MSP configuration on MSP peripherals Enable MSP configuration on MSP peripherals Oct 30, 2022
@ctzsnooze ctzsnooze merged commit 35ca9fc into betaflight:master Oct 31, 2022
Finalizing Firmware 4.4 Release automation moved this from Configurator to Closed Oct 31, 2022
@haslinghuis haslinghuis deleted the enforce-msp branch October 31, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@asizon asizon Awaiting requested review from asizon

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: IMPROVEMENT RN: REFACTOR
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haslinghuis @blckmn @McGiverGim @limonspb @ctzsnooze